fix(tests): resolve two pre-existing main CI failures#531
Open
blove wants to merge 1 commit into
Open
Conversation
1. **libs/langgraph agent.provider.spec.ts** — "runs a silent license check when a valid license is supplied" was using the legacy tier slug `'developer-seat'` (hyphen), but PR #516 (May 21) renamed the `LicenseTier` union to underscored slugs (`'developer_seat'`). The token was rejected as `malformed` by `parseLicenseToken`, the warn nag fired, and the test failed. Update the test to use the new slug. 2. **apps/website e2e website.spec.ts** — "pricing page lead form validates required fields" clicked `button[type="submit"]` without scoping, which picked the first such button on the page. Stripe Checkout (PR #508) added a `<form action="/api/checkout/session" method="post">` with a submit button per buyable tier — those now appear before the LeadForm's "Get in touch" button. The test was POSTing to /api/checkout/session, which hit getStripe() with no STRIPE_SECRET_KEY in CI and 500'd, leaving the page in a state without any visible form. Scope the click + assertion to the LeadForm via the "Get in touch" button text. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated test failures had been red on main since recent merges:
Library — lint / test / build failing on
langgraph:test—agent.provider.spec.tsused legacy tier slug'developer-seat'(hyphen). PR fix(minting): handle one-time-payment Checkout sessions + align tier slugs (PR D) #516 renamed theLicenseTierunion to underscored slugs ('developer_seat'). Token was rejected as malformed → nag fired → test failed.Website — e2e failing on "pricing page lead form validates required fields" — bare
page.click('button[type="submit"]')was picking the first submit button, which after PR feat(website): Stripe Checkout for paid pricing tiers (PR B-Stripe) #508 became a Stripe checkout button (POSTs to/api/checkout/sessionwhich 500s withoutSTRIPE_SECRET_KEY). Scoped to the LeadForm via the "Get in touch" button text.Test plan
npx vitest run agent.providerlocally — 4/4 passing🤖 Generated with Claude Code